[asterisk-dev] [Code Review]: chan_dahdi: Add dialtonedetect option

[rmudgett]

> On Feb. 13, 2012, 2:55 p.m., rmudgett wrote:
> > trunk/channels/chan_dahdi.c, lines 9272-9274
> > <https://reviewboard.asterisk.org/r/1737/diff/1/?file=24156#file24156line9272>
> >
> >     This code will break the dialtone detection for outgoing calls checked later.  (See code dealing with p->waitingfordt)
> 
> Jeremy Pepper wrote:
>     I see. To avoid this, it looks like I'll want to drop the new frame type and check the DSP state the same way waitingfordt does. Does this make sense to you?

Yes.  That is what I was thinking because of all the other files you would have to touch to add the new control frame type.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1737/#review5486
-----------------------------------------------------------


On Feb. 13, 2012, 1:33 p.m., Jeremy Pepper wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1737/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2012, 1:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi: Add dialtonedetect option
> 
> This adds an option to chan_dahdi.conf called dialtonedetect. This can be set like this:
> 
>     dialtonedetect = yes ; Watch for dialtone for 10 seconds after answer
>     dialtonedetect = always ; Watch for dialtone for the whole call
>     dialtonedetect = 5000 ; Watch for dialtone for 5000ms
> 
> If dialtone is detected on an inbound call, Asterisk will hang up the channel.
> 
> 
> This addresses bug ASTERISK-19316.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19316
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 354459 
>   trunk/configs/chan_dahdi.conf.sample 354459 
>   trunk/include/asterisk/frame.h 354459 
>   trunk/main/dsp.c 354459 
> 
> Diff: https://reviewboard.asterisk.org/r/1737/diff
> 
> 
> Testing
> -------
> 
> This patch has been installed on an Asterisk box connected to another Asterisk box simulating an upstream carrier. Testing was done with dialtonedetect off, set to always, set to yes, and set to a custom value.
> 
> 
> Thanks,
> 
> Jeremy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120213/8793569f/attachment-0001.htm>