[asterisk-dev] [Code Review] Opaquify const char * and char[] in the ast_channel

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1733/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Next up, char * and char[] fields.


Diffs
-----

  /trunk/apps/app_rpt.c 354785 
  /trunk/apps/app_readexten.c 354785 
  /trunk/apps/app_fax.c 354785 
  /trunk/apps/app_macro.c 354785 
  /trunk/apps/app_meetme.c 354785 
  /trunk/apps/app_minivm.c 354785 
  /trunk/apps/app_osplookup.c 354785 
  /trunk/apps/app_parkandannounce.c 354785 
  /trunk/apps/app_queue.c 354785 
  /trunk/apps/app_dumpchan.c 354785 
  /trunk/apps/app_directed_pickup.c 354785 
  /trunk/apps/app_directory.c 354785 
  /trunk/apps/app_dial.c 354785 
  /trunk/apps/app_chanspy.c 354785 
  /trunk/apps/app_confbridge.c 354785 
  /trunk/addons/chan_mobile.c 354785 
  /trunk/addons/chan_ooh323.c 354785 
  /trunk/apps/app_stack.c 354785 
  /trunk/apps/app_talkdetect.c 354785 
  /trunk/apps/app_verbose.c 354785 
  /trunk/apps/app_voicemail.c 354785 
  /trunk/apps/app_while.c 354785 
  /trunk/bridges/bridge_builtin_features.c 354785 
  /trunk/channels/chan_agent.c 354785 
  /trunk/channels/chan_alsa.c 354785 
  /trunk/channels/chan_dahdi.c 354785 
  /trunk/channels/chan_gtalk.c 354785 
  /trunk/channels/chan_h323.c 354785 
  /trunk/channels/chan_iax2.c 354785 
  /trunk/channels/chan_jingle.c 354785 
  /trunk/channels/chan_local.c 354785 
  /trunk/channels/chan_mgcp.c 354785 
  /trunk/channels/chan_misdn.c 354785 
  /trunk/channels/chan_nbs.c 354785 
  /trunk/channels/chan_oss.c 354785 
  /trunk/channels/chan_phone.c 354785 
  /trunk/channels/chan_sip.c 354785 
  /trunk/channels/chan_skinny.c 354785 
  /trunk/channels/chan_unistim.c 354785 
  /trunk/channels/sig_analog.c 354785 
  /trunk/channels/sig_pri.c 354785 
  /trunk/funcs/func_channel.c 354785 
  /trunk/funcs/func_dialplan.c 354785 
  /trunk/include/asterisk/channel.h 354785 
  /trunk/main/ccss.c 354785 
  /trunk/main/cdr.c 354785 
  /trunk/main/cel.c 354785 
  /trunk/main/channel.c 354785 
  /trunk/main/channel_internal_api.c 354785 
  /trunk/main/cli.c 354785 
  /trunk/main/dial.c 354785 
  /trunk/main/features.c 354785 
  /trunk/main/file.c 354785 
  /trunk/main/manager.c 354785 
  /trunk/main/pbx.c 354785 
  /trunk/pbx/pbx_dundi.c 354785 
  /trunk/pbx/pbx_lua.c 354785 
  /trunk/pbx/pbx_realtime.c 354785 
  /trunk/res/res_agi.c 354785 
  /trunk/res/res_calendar.c 354785 
  /trunk/res/res_fax.c 354785 
  /trunk/res/snmp/agent.c 354785 
  /trunk/tests/test_substitution.c 354785 

Diff: https://reviewboard.asterisk.org/r/1733/diff


Testing
-------

It compiles, and the unittests all run (one tests had to be modified to use accessors).


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120211/28f5d366/attachment-0001.htm>