[asterisk-dev] [Code Review] Add tests to check parsing of compact and non-compact headers

Mark Michelson reviewboard at asterisk.org
Thu Feb 9 14:16:55 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1729/#review5474
-----------------------------------------------------------

Ship it!


Cool beans

- Mark


On Feb. 9, 2012, 1:20 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1729/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2012, 1:20 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds a header parsing test under SIP to test compact vs non-compact header parsing and adds a place to put future header-parsing tests (in contrast with the primarily SDP related parsing tests in codec_negotiation).
> 
> 
> This addresses bug ASTERISK-17192.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17192
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/SIP/header_parsing/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/tests.yaml 3027 
>   asterisk/trunk/tests/channels/SIP/header_parsing/sipp/mixed_compact_inverse.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/header_parsing/sipp/mixed_compact.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/header_parsing/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/header_parsing/run-test PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/header_parsing/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1729/diff
> 
> 
> Testing
> -------
> 
> Tested before and after the patch:
> https://reviewboard.asterisk.org/r/1728/
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120209/c9baa980/attachment-0001.htm>


More information about the asterisk-dev mailing list