[asterisk-dev] [Code Review] Add test for LEN function which includes testing for config escapes

Mark Michelson reviewboard at asterisk.org
Thu Feb 9 13:45:24 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1727/#review5473
-----------------------------------------------------------

Ship it!


Looks good to me.

- Mark


On Feb. 9, 2012, 1:12 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1727/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2012, 1:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Adds a test for LEN function and also tests proper evaluation of config semicolon escapes.
> 
> 
> This addresses bug ASTERISK-17121.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17121
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/dialplan/configs/ast1/extensions.conf 3027 
> 
> Diff: https://reviewboard.asterisk.org/r/1727/diff
> 
> 
> Testing
> -------
> 
> Test ran before and after patch here:
> https://reviewboard.asterisk.org/r/1724/
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120209/ec1ff303/attachment.htm>


More information about the asterisk-dev mailing list