[asterisk-dev] [Code Review] Add SIP INFO DTMF test to the Asterisk Test Suite

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1723/#review5451
-----------------------------------------------------------

Ship it!


few minor comments, looks good


/asterisk/trunk/tests/channels/SIP/info_dtmf/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1723/#comment10040>

    boo, wait(10)



/asterisk/trunk/tests/channels/SIP/info_dtmf/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1723/#comment10039>

    udpbindaddr=127.0.0.1:5060



/asterisk/trunk/tests/channels/SIP/info_dtmf/run-test
<https://reviewboard.asterisk.org/r/1723/#comment10041>

    redundant


- Paul


On Feb. 9, 2012, 9:15 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1723/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2012, 9:15 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds a test to the Asterisk Test Suite to cover the regression that was introduced in ASTERISK-18924.  This test sends a sequence of SIP INFO requests containing DTMF events covering 0-9, A-D, a-d, and 10-16.  This checks only for SIP INFO requests that have a Content-Type of application/dtmf-relay; the test could be expanded to cover the less used Content-Type of application/dtmf if we feel its necessary.
> 
> 
> This addresses bug ASTERISK-19290.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19290
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/info_dtmf/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/info_dtmf/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/info_dtmf/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/info_dtmf/sipp/dtmf-relay.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/info_dtmf/sipp/dtmf.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/info_dtmf/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 3027 
> 
> Diff: https://reviewboard.asterisk.org/r/1723/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120209/7274cb9a/attachment-0001.htm>