[asterisk-dev] [Code Review] Make callbackextension work for realtime and also match on callbackextension when multiple peers with the same host have differing callbackextensions

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1717/#review5440
-----------------------------------------------------------


Looks good to me.

A mention in the CHANGES might be worthwhile though. Especially since we now get a new warning "no such column: callbackextension" when starting up without such a column.


/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1717/#comment10027>

    s/Frist/First/



/trunk/channels/sip/include/sip.h
<https://reviewboard.asterisk.org/r/1717/#comment10029>

    Spaces?


- wdoekes


On Feb. 7, 2012, 2:11 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1717/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2012, 2:11 p.m.)
> 
> 
> Review request for Asterisk Developers and wdoekes.
> 
> 
> Summary
> -------
> 
> This patch is a continuation of the one on https://reviewboard.asterisk.org/r/344/. If multiple peers are defined with the same host/port, but differing callbackextensions, it chooses the peer with the matching callbackextension. Since callbackextension creates an outbound registration with the callbackextension as the Contact address, matching an incoming request by that (in addition to the host/port) makes a lot of sense.
> 
> This patch also adds support for callbackextension to realtime by querying all peers with callbackextensions on reload and adding registrations for them. The patch on /r/344 didn't support matching realtime peers, but this one does.
> 
> While callbackextension certainly has its detractors, it is what we have to work with at this time and we should make it work until we have a better solution available.
> 
> 
> This addresses bug ASTERISK-13456.
>     https://issues.asterisk.org/jira/browse/ASTERISK-13456
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 353913 
>   /trunk/channels/sip/include/sip.h 353913 
>   /trunk/contrib/realtime/postgresql/realtime.sql 353913 
> 
> Diff: https://reviewboard.asterisk.org/r/1717/diff
> 
> 
> Testing
> -------
> 
> I set up outbound registrations via differing callbackextensions for two peers with the same host/port. I then dialed from the Asterisk box that those peers were registered to and verified that the correct peer was matched in each case. I tried this with realtime and non-realtime configs.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120208/fa6687bc/attachment-0001.htm>