[asterisk-dev] [Code Review]: Remove some dead code found in _sip_show_peers()

[Paul Belanger]

> On Jan. 26, 2012, 2:54 p.m., wdoekes wrote:
> > trunk/channels/chan_sip.c, line 17240
> > <https://reviewboard.asterisk.org/r/1696/diff/1/?file=23661#file23661line17240>
> >
> >     for<space>(

ack'd


> On Jan. 26, 2012, 2:54 p.m., wdoekes wrote:
> > trunk/channels/chan_sip.c, lines 17284-17290
> > <https://reviewboard.asterisk.org/r/1696/diff/1/?file=23661#file23661line17284>
> >
> >     Isn't the lack of indentation here more worrisome than the missing braces above?
> >     
> >     (And the same issue with astman_append below.)

I'll clean this up


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1696/#review5313
-----------------------------------------------------------


On Jan. 26, 2012, 10:59 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1696/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2012, 10:59 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I was poking around in chan_sip last night (scary right?) and notice what appears to be some dead code.  This patch removes it and also includes come coding guidelines.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 352754 
> 
> Diff: https://reviewboard.asterisk.org/r/1696/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120202/dac217e2/attachment-0001.htm>