[asterisk-dev] [Code Review]: Add connected line test based on the new bridging test object

[opticron]

> On Dec. 18, 2012, 4:11 p.m., Mark Michelson wrote:
> > asterisk/trunk/tests/bridge/connected_line_update/configs/ast1/sip.conf, lines 5-6
> > <https://reviewboard.asterisk.org/r/2249/diff/1/?file=32462#file32462line5>
> >
> >     I'd be fine with these options being added to the configs/bridge/astX/sip.conf files so that you don't need any sip.conf files for this test specifically.
> >     
> >     Alternatively, so you don't have to reproduce the entirely sip.conf file, the sip.conf files in configs/bridge/astX can be made "extensible" similar to how the extensions.conf files were done there.

Extensified.


> On Dec. 18, 2012, 4:11 p.m., Mark Michelson wrote:
> > asterisk/trunk/tests/bridge/connected_line_update/Tester.py, lines 62-65
> > <https://reviewboard.asterisk.org/r/2249/diff/1/?file=32460#file32460line62>
> >
> >     This is only going to work if we can guarantee that starpy is going to call into this user event callback after it calls into the BridgeTestCase's callback for TalkDetect. Otherwise, there could be issues since the BridgeTestCase will be trying to check connected line values against its expectations after you have changed connected line to be something else entirely.

The BridgeTestCase will now emit a UserEvent "features_executed" upon completion of automated feature testing that this test will key off of.


> On Dec. 18, 2012, 4:11 p.m., Mark Michelson wrote:
> > asterisk/trunk/tests/bridge/connected_line_update/test-config.yaml, lines 33-41
> > <https://reviewboard.asterisk.org/r/2249/diff/1/?file=32465#file32465line33>
> >
> >     What causes these first three CLInfo events to happen?
> >     
> >     I assume there is one when Bob answers the call, but I don't know what the other two are. Bob's phone doesn't ring so I there shouldn't be any provisional responses with connected line updates in them.

The first occurs when Bob sends the 100 trying.  The second and third happen just after the UUT ACKs the call to Bob.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2249/#review7549
-----------------------------------------------------------


On Dec. 18, 2012, 2:58 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2249/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 2:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds a test based on Mark's bridging test object that checks for bidirectional transfer of connected line information through an instance of Asterisk sitting between two other instances of Asterisk.
> 
> 
> This addresses bug SWP-4713.
>     https://issues.asterisk.org/jira/browse/SWP-4713
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/bridge/connected_line_update/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/bridge/connected_line_update/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/bridge/connected_line_update/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/bridge/connected_line_update/configs/ast3/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/bridge/connected_line_update/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/bridge/tests.yaml 3579 
>   asterisk/trunk/tests/bridge/connected_line_update/Tester.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2249/diff
> 
> 
> Testing
> -------
> 
> Verified that the test was working properly via logs output by the test.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121231/60f219c9/attachment-0001.htm>