[asterisk-dev] [Code Review] Expand MEETME_INFO() with new options

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/812/#review7588
-----------------------------------------------------------



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/812/#comment14468>

    I dislike the way this has gotten structured - we now have:
    
    -1: invalid keyword, returned from acf_meetme_info_eval
    -2: conference not found, not returned from acf_meetme_info_eval
    -3: not an error but rather a signal to not copy the result into the buffer, returned from acf_meetme_info_eval.
    
    Yikes.
    
    Instead of that, why not have acf_meetme_info_eval *always* copy the result into buf, and return success or error?  That eliminates needing to return -3, and simplifies the code here.


- Matt


On Dec. 14, 2012, 6:56 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/812/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2012, 6:56 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Simple patch that expands MEETME_INFO() with a few new options. 
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 378017 
> 
> Diff: https://reviewboard.asterisk.org/r/812/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121231/ad90c24d/attachment.htm>