[asterisk-dev] [Code Review] res_sip and res_sip_session design review

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2251/
-----------------------------------------------------------

Review request for Asterisk Developers, Matt Jordan and jcolp.


Summary
-------

This is a proposal for a res_sip and res_sip_session API for use in the new SIP channel driver. The pages are located here:

https://wiki.asterisk.org/wiki/display/AST/res_sip+design
https://wiki.asterisk.org/wiki/display/AST/res_sip_session+design

Please let me know what you think of these.

There are a few things that are not here and that probably should
* A struct called ast_sip_endpoint is referenced in a few places, but it is not defined. This is because a SIP endpoint is more-or-less defined by the DAL, which is currently under development by Mr. Joshua Colp. Once endpoint configuration and related structures are defined, they can be added in to these pages.
* There are no functions in res_sip_session for iterating over SDP media streams or attributes, nor are there any functions for aiding in creating SDPs. These likely should exist, but I have not placed them here now since I have difficulty seeing what parameters will be necessary nor what they might return.


Diffs
-----


Diff: https://reviewboard.asterisk.org/r/2251/diff


Testing
-------

The wiki page renders properly.


Thanks,

Mark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121220/1c215d90/attachment-0001.htm>