[asterisk-dev] [Code Review] Add GroupPickup to Skinny

[wedhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2246/
-----------------------------------------------------------

(Updated Dec. 18, 2012, 1:11 a.m.)


Review request for Asterisk Developers and Brad Latus.


Changes
-------

Added namedgroup pickup courtesy of snuffy.

Effectively reads namedgroups from skinny.conf and stores as an ao2 object on the skinny line and points to them on chan create. Initial patch does the rest.


Summary
-------

Adds group pickup to chan_skinny.

Code does not include hangup cause as skinny doesn't deal with it (yet). Happy to add seeing as it can interact with other tech.


Diffs (updated)
-----

  /trunk/channels/chan_skinny.c 378014 

Diff: https://reviewboard.asterisk.org/r/2246/diff


Testing
-------

Pickup a call to a skinny device, pickup a call to a sip device, try to pickup when no call available. All good.


Thanks,

wedhorn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121218/eda1aed4/attachment.htm>