[asterisk-dev] [Code Review]: Add aliases for Directory

[Tilghman Lesher]

> On Dec. 13, 2012, 12:49 p.m., Mark Michelson wrote:
> > /trunk/apps/app_directory.c, lines 656-663
> > <https://reviewboard.asterisk.org/r/2244/diff/1/?file=32386#file32386line656>
> >
> >     IMO, this should only be done if OPT_LISTBYFIRSTNAME is set.
> 
> Tilghman Lesher wrote:
>     I toyed with this idea, but I went with always searching the alias no matter what, because it improves searching.  If anything, I'd suggest a flag unique to aliases to search them (like 'a').  What do you think?
> 
> Mark Michelson wrote:
>     My thought on this is to either
>     
>     1) Add an 'a' flag or some such in order to explicitly allow alias searching
>     2) Use alias searching when OPT_LISTBYFIRSTNAME is set.
>     
>     The reason for this is that I foresee most aliases being used for cases where someone who is calling for the person in question *thinks* that they are searching for the person's first name and isn't aware that they're using an alias. For instance, iirc, "Tilghman" isn't your first name, but most people probably think it is. So if they were searching for you in a directory using first name as an index, they would probably search for "Tilghman", unaware that it's actually an alias. Same goes for people who typically go by shortened forms of their first name. They may be listed in the directory as "Robert" but we could allow an alias of "Bob" since most people calling in know him as that.
>     
>     I think suggestion number 1) is the best solution since it follows principle of least surprise. Administrators will know straight away that by enabling the 'a' flag, they're allowing an alias search. The big thing to keep in mind is that the flag should "stack" so to speak. In other words, if alias searching is allowed, that shouldn't exclude the ability to also search by first or last name.

Sounds good to me.  Changed.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2244/#review7533
-----------------------------------------------------------


On Dec. 17, 2012, 5:26 p.m., Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2244/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2012, 5:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds extra strings for comparison in the Directory application.  The purpose of this is to enable nicknames that otherwise would not be compared.  For example, Bob "Bongo Boy" Berman might have an alias of "Bongo", for which he would be searchable, even though his name would not normally include it.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_directory.c 377511 
>   /trunk/configs/voicemail.conf.sample 377511 
>   /trunk/contrib/realtime/mysql/voicemail.sql 377511 
> 
> Diff: https://reviewboard.asterisk.org/r/2244/diff
> 
> 
> Testing
> -------
> 
> Deployed and working on a production machine.
> 
> 
> Thanks,
> 
> Tilghman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121217/d2a2d736/attachment-0001.htm>