[asterisk-dev] [Code Review]: Add aliases for Directory

[Tilghman Lesher]

> On Dec. 13, 2012, 12:49 p.m., Mark Michelson wrote:
> > I like this feature. The big thing that's missing here is updated documentation for voicemail.conf and realtime voicemail config.

Added.


> On Dec. 13, 2012, 12:49 p.m., Mark Michelson wrote:
> > /trunk/apps/app_directory.c, lines 492-498
> > <https://reviewboard.asterisk.org/r/2244/diff/1/?file=32386#file32386line492>
> >
> >     The strcmp here should be strcasecmp since ast_variable_retrieve() does a case-insensitive comparison.

Changed.


> On Dec. 13, 2012, 12:49 p.m., Mark Michelson wrote:
> > /trunk/apps/app_directory.c, lines 611-621
> > <https://reviewboard.asterisk.org/r/2244/diff/1/?file=32386#file32386line611>
> >
> >     Since you use strcasestr, you should use strcasecmp.

Changed.


> On Dec. 13, 2012, 12:49 p.m., Mark Michelson wrote:
> > /trunk/apps/app_directory.c, lines 656-663
> > <https://reviewboard.asterisk.org/r/2244/diff/1/?file=32386#file32386line656>
> >
> >     IMO, this should only be done if OPT_LISTBYFIRSTNAME is set.

I toyed with this idea, but I went with always searching the alias no matter what, because it improves searching.  If anything, I'd suggest a flag unique to aliases to search them (like 'a').  What do you think?


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2244/#review7533
-----------------------------------------------------------


On Dec. 12, 2012, 6:19 p.m., Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2244/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 6:19 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds extra strings for comparison in the Directory application.  The purpose of this is to enable nicknames that otherwise would not be compared.  For example, Bob "Bongo Boy" Berman might have an alias of "Bongo", for which he would be searchable, even though his name would not normally include it.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_directory.c 377511 
> 
> Diff: https://reviewboard.asterisk.org/r/2244/diff
> 
> 
> Testing
> -------
> 
> Deployed and working on a production machine.
> 
> 
> Thanks,
> 
> Tilghman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121217/3dc95625/attachment-0001.htm>