[asterisk-dev] [Code Review]: Expand MEETME_INFO() with new options

[Olle E Johansson]

> On July 28, 2010, 11:08 a.m., Russell Bryant wrote:
> > /trunk/apps/app_meetme.c, line 6802
> > <https://reviewboard.asterisk.org/r/812/diff/1/?file=11952#file11952line6802>
> >
> >     space after 1

fixed


> On July 28, 2010, 11:08 a.m., Russell Bryant wrote:
> > /trunk/apps/app_meetme.c, lines 6806-6808
> > <https://reviewboard.asterisk.org/r/812/diff/1/?file=11952#file11952line6806>
> >
> >     You don't need 'now'.  Just call time(NULL) in your args to snprintf().  Also, look for other places where a time_t is used with a format string.  IIRC, this will produce a compiler warning on some systems.

fixed.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/812/#review2489
-----------------------------------------------------------


On July 28, 2010, 5:01 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/812/
> -----------------------------------------------------------
> 
> (Updated July 28, 2010, 5:01 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Simple patch that expands MEETME_INFO() with a few new options. 
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 280055 
> 
> Diff: https://reviewboard.asterisk.org/r/812/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121214/afaac814/attachment.htm>