[asterisk-dev] [Code Review]: Implement Externaddr on a sip device basis

[Olle E Johansson]

> On Oct. 27, 2011, 1:35 p.m., wdoekes wrote:
> > /trunk/channels/chan_sip.c, line 28608
> > <https://reviewboard.asterisk.org/r/1471/diff/1/?file=20909#file20909line28608>
> >
> >     Why is an empty externaddr= setting now allowed without warning? It doesn't seem consistent with the other settings. Or does this serve a purpose I don't see?
> 
> Olle E Johansson wrote:
>     I honestly don't know. Will lock at this. Thanks for the feedback!

Fixed.


> On Oct. 27, 2011, 1:35 p.m., wdoekes wrote:
> > /trunk/channels/chan_sip.c, lines 3488-3489
> > <https://reviewboard.asterisk.org/r/1471/diff/1/?file=20909#file20909line3488>
> >
> >     ast_sockaddr_stringify uses a static buffer: ast_strdupa()

Fixed.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1471/#review4599
-----------------------------------------------------------


On Sept. 29, 2011, 7:14 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1471/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2011, 7:14 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently, the Asterisk SIP channel can only handle one externaddr per host. With this patch, every peer can have a externaddr setting so that we can have different externaddr for different SIP trunks.
> 
> 
> This addresses bug ASTERISK-18643.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18643
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 338415 
>   /trunk/channels/chan_sip.c 338373 
>   /trunk/channels/sip/include/sip.h 338373 
>   /trunk/configs/sip.conf.sample 338373 
> 
> Diff: https://reviewboard.asterisk.org/r/1471/diff
> 
> 
> Testing
> -------
> 
> The 1.4 version has been in production for about a year in a large call center.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121214/5a9d1cc5/attachment.htm>