[asterisk-dev] [Code Review] Rewrite skinny dialing to remove threaded simpleswitch

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2240/#review7536
-----------------------------------------------------------


Unrelated minor changes or tweaks should probably be committed so as to avoid scope creep in this review.


/branches/11/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2240/#comment14325>

    Like this.



/branches/11/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2240/#comment14326>

    and this.



/branches/11/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2240/#comment14327>

    and this.



/branches/11/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2240/#comment14328>

    and this.



/branches/11/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2240/#comment14322>

    This should probably be addressed before commit via removal of the branch or ensuring that the tone is heard.



/branches/11/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2240/#comment14323>

    I completely agree with this FIXME.



/branches/11/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2240/#comment14324>

    Remove this.


- opticron


On Dec. 12, 2012, 12:06 a.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2240/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 12:06 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This rewrite changes skinny dialing from the threaded simpleswitch to a scheduled timeout approach. There were some underlying issues with the threaded simple switch with occasional corruption and possible segfaults.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_skinny.c 376620 
> 
> Diff: https://reviewboard.asterisk.org/r/2240/diff
> 
> 
> Testing
> -------
> 
> Lots of dialing. Incomplete numbers timeout, complete numbers dial and behave as expected.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121213/ef5bbdfb/attachment.htm>