[asterisk-dev] [Code Review] Change dynamic features buffer to use ast_str instead of a fixed sized buffer

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2221/#review7509
-----------------------------------------------------------

Ship it!


- Matt


On Dec. 4, 2012, 11:33 p.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2221/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2012, 11:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently, the buffer for the dynamic features list is being set to a fixed size of 128.  If the list is bigger than that, it obviously results in the dynamic feature not working.
> 
> This patch attempts to change the buffer from a fixed size to a dynamic one.
> 
> Is this a candidate for all branches?
> 
> 
> This addresses bug ASTERISK-20680.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20680
> 
> 
> Diffs
> -----
> 
>   /branches/11/main/features.c 376416 
> 
> Diff: https://reviewboard.asterisk.org/r/2221/diff
> 
> 
> Testing
> -------
> 
> Local dev box.  I was waiting for the reporter to test it as well but I haven't heard back yet.
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121207/a9a1a295/attachment.htm>