[asterisk-dev] [Code Review]: dsp.c: dtmf_detect, Fix multiple issues when no-interdigit delay is present.

[rmudgett]

> On Aug. 30, 2012, 4:05 p.m., rmudgett wrote:
> > trunk/main/dsp.c, line 746
> > <https://reviewboard.asterisk.org/r/2085/diff/2/?file=31096#file31096line746>
> >
> >     B should have ended here as there were two misses of B.
> 
> Alec Davis wrote:
>     I'd considered that, but if both hits_to_begin = 2 and and misses_to_end = 2, then both need to fire at the same time.
>     The begin has priority, and the code works if no previous END was received.
>     
>     
>     
>

True.  However, with begin=3 and end=2 as in your example, B should end.  Also is B's time stretched as a result?


> On Aug. 30, 2012, 4:05 p.m., rmudgett wrote:
> > trunk/main/dsp.c, line 750
> > <https://reviewboard.asterisk.org/r/2085/diff/2/?file=31096#file31096line750>
> >
> >     C should end here as there were two misses of C.
> 
> Alec Davis wrote:
>     IIRC the DTMF spec says '2' continuous hits of the same BEGIN digit or silence.

To which spec are you referring?


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2085/#review6983
-----------------------------------------------------------


On Aug. 28, 2012, 5:47 p.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2085/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2012, 5:47 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Document DTMF events for different sequences.
> 
> * Fix extra hit required when new DIGIT is sent without any interdigit delay.
> * Fix when DTMF_HITS_TO_BEGIN = 2, and no interdigit gap, that BEGIN is posted. 
> * Fix situation where a flakey detect, would clear the current_hit (indicating an END), which may not have been the case.
> 
> 
> Diffs
> -----
> 
>   trunk/main/dsp.c 371689 
> 
> Diff: https://reviewboard.asterisk.org/r/2085/diff
> 
> 
> Testing
> -------
> 
> On production box for 24 hours. 888 digit's now received.
> 
> The change here doesn't affect normal tone on/tone off, it changes the case when no interdigit pause is received between 2 digits, now the 2 digit has the same detect time as if there had been an interdigit pause before hand.
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120830/8d4b6f1e/attachment-0001.htm>