[asterisk-dev] [Code Review] Fix SEQNO on retransmitted DTMF event END packets not being incremented

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2083/#review6975
-----------------------------------------------------------

Ship it!


- Mark


On Aug. 24, 2012, 12:01 p.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2083/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2012, 12:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When sending the DTMF event END packet, the two retransmitted packets have the same sequence number as the first transmitted packet.
> 
> RFC 4733 Sect. 2.5.1.6. RTP Sequence Number
> "The RTP sequence number MUST be incremented by one in each successive RTP packet sent. Incrementing applies to retransmitted as well as initial instances of event reports, to permit the receiver to detect lost packets for RTP Control Protocol (RTCP) receiver reports."
> 
> This patch is based on the reporters patch which I have fixed up to meet our code submission guidelines and moved the incrementation of seqno down to below a debug message so that the debug message displays the correct seqno that was transmitted.
> 
> Cleaned up a couple of lines as well while I was looking at the code that were essentially not needed.
> 
> 
> This addresses bug ASTERISK-20295.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20295
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_rtp_asterisk.c 371620 
> 
> Diff: https://reviewboard.asterisk.org/r/2083/diff
> 
> 
> Testing
> -------
> 
> Tested on local dev box.  Did a packet capture to confirm that the seqno was being incremented properly when sending DTMF.
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120830/4741617b/attachment.htm>