[asterisk-dev] [svn-commits] jrose: trunk r371889 - in /trunk: UPGRADE.txt channels/chan_sip.c

[Matthew Jordan]

----- Original Message -----
> From: "Olle E. Johansson" <oej at edvina.net>
> To: "Asterisk Developers Mailing List" <asterisk-dev at lists.digium.com>
> Cc: asterisk-commits at lists.digium.com, "Olle E. Johansson" <oej at edvina.net>
> Sent: Thursday, August 30, 2012 3:05:50 AM
> Subject: Re: [asterisk-dev] [svn-commits] jrose: trunk r371889 - in /trunk:	UPGRADE.txt channels/chan_sip.c
> 
> 
> 29 aug 2012 kl. 21:38 skrev SVN commits to the Digium repositories
> <svn-commits at lists.digium.com>:
> 
> > Author: jrose
> > Date: Wed Aug 29 14:38:52 2012
> > New Revision: 371889
> > 
> > URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=371889
> > Log:
> > chan_sip: Change manager event to confirm SIPqualifypeer into an
> > ack
> > 
> > Matt Jordan  informed me that it was more appropriate to use an
> > astman_send_ack here instead of making an event response. I've also
> > used this opportunity to update UPGRADE.txt to mention this change
> > in behavior.
> 
> Well, if you look at the action/response logic it's correct, but then
> we need to make
> it asynchrous like originate. Otherwise you can block the manager for
> new actions
> for a very long time.
> 
> 1. Action
> 2. Response - "will do"
> 3. Event with result
> 
> The SIP OPTIONS with retransmits may take a long time to complete.
> 
> /O

Totally agree about the need for the response to occur before the qualify.

Do you think we really need an event with the result?  It feels like that
information is best obtained by retrieving the peer status.

--
Matthew Jordan
Digium, Inc. | Engineering Manager
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: http://digium.com & http://asterisk.org