[asterisk-dev] [Code Review] refactor dsp.c that can no longer detect a quick DTMF sequence.

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2084/
-----------------------------------------------------------

(Updated Aug. 25, 2012, 7:57 p.m.)


Review request for Asterisk Developers, rmudgett and Jason Parker.


Changes
-------

Added DTMF event sequences that will trigger BEGIN or END

                /*  ------AA    Begin A
                 *  -----AA-    no change
                 *  ----AA--    End A
                 *  ---AA--B    no change
                 *  --AA--BC    no change
                 *  -AA--BCC    Start C
                 *  AA--BCCD    no change
                 *  A--BCCDD    Start D
                 *  --BCCDD-    no change
                 *  -BCCDD-E    no change
                 *  BCCDD-EE    Start E
                 *  CCDD-EE-    no change
                 *  CDD-EE-F    no change
                 *  DD-EE-F-    no change
                 *  D-EE-F--    End E
                 */


Summary
-------

Use a simpler method to detect changes in DTMF ON/OFF tones.

Similar method to latest spandsp/dtmf.c
   We must detect 2 silences for DTMF END.

Reverts some of 111022 that added DTMF_HITS_TO_BEGIN and DTMF_MISSES_TO_END


This addresses bugs ASTERISK-17493 and ASTERISK-19610.
    https://issues.asterisk.org/jira/browse/ASTERISK-17493
    https://issues.asterisk.org/jira/browse/ASTERISK-19610


Diffs (updated)
-----

  trunk/main/dsp.c 371649 

Diff: https://reviewboard.asterisk.org/r/2084/diff


Testing
-------


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120826/caaf6d4c/attachment.htm>