[asterisk-dev] [svn-commits] file: branch 11 r371619 - /branches/11/channels/chan_motif.c

[Paul Belanger]

On 12-08-22 02:49 PM, Joshua Colp wrote:
> ----- Original Message -----
>> On 12-08-22 11:54 AM, SVN commits to the Digium repositories wrote:
>>> Author: file
>>> Date: Wed Aug 22 10:54:18 2012
>>> New Revision: 371619
>>>
>>> URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=371619
>>> Log:
>>> Add support for call-id logging to chan_motif.
>>>
>>> Review: https://reviewboard.asterisk.org/r/2077/
>>>
>>> Modified:
>>>       branches/11/channels/chan_motif.c
>>>
>> Sorry to be _that_ guy, but I am curious why we are still merging new
>> features into Asterisk 11, especially after we have branches and
>> released -beta1?
>>
>> We are already 4 weeks over the feature freeze date[1].  Are we still
>> expecting more features?  Should this be removed?
>
> The fundamental call-id logging feature was obviously in before that date, as was chan_motif itself. Both things were developed at the same time and implementing the minor changes required in chan_motif for call-id logging didn't quite make it. Personally I made the call to put it into 11 because it's on the line between a new feature and something that should have been there. It's also very non-invasive, limited to a single new module. If this discussion leads to keeping this out, so be it.
>
It's not my call to keep it in or out, I'm just bringing up the fact we 
explicitly say feature freeze is the 3rd Wednesday in July. If we, as a 
project, cannot make that date we should send out notifications of the 
slip.  This way other people have the opportunity to get their (late) 
patches in.

Personally, I would rather slip the date, get all the new features in, 
then branch and release. I just don't like branching and releasing, then 
trying to add more features afterwards.  From a testing perspective, 
this is just wrong.

-- 
Paul Belanger | PolyBeacon, Inc.
Jabber: paul.belanger at polybeacon.com | IRC: pabelanger (Freenode)
Github: https://github.com/pabelanger | Twitter: 
https://twitter.com/pabelanger