[asterisk-dev] [Code Review] Add callid logging support to chan_motif

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2077/#review6923
-----------------------------------------------------------

Ship it!


This looks good aside from one thing which is pretty minor:


/branches/11/channels/chan_motif.c
<https://reviewboard.asterisk.org/r/2077/#comment13525>

    ast_read_threadstorage_callid will grab a reference to the callid if it is available from threadstorage.
    
    There are at least two returns from here where this reference is leaked. When you assign session->callid, you aren't bumping the reference count if it's already there, so at that point it isn't at risk of being leaked anymore.


- jrose


On Aug. 17, 2012, 1 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2077/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2012, 1 p.m.)
> 
> 
> Review request for Asterisk Developers and jrose.
> 
> 
> Summary
> -------
> 
> This patch adds support for call-id logging within chan_motif. It's created or stored as needed, associated with the iksemel thread, and unreferred afterwards.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_motif.c 371424 
> 
> Diff: https://reviewboard.asterisk.org/r/2077/diff
> 
> 
> Testing
> -------
> 
> Testing various scenarios to confirm call-id is used and appears.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120817/e33e9cd2/attachment.htm>