[asterisk-dev] [Code Review] app_alarmreceiver cleanup and fixes

[KNK]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2075/
-----------------------------------------------------------

(Updated Aug. 17, 2012, 9:54 a.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed my own findings in the review and some other discovered later.


Summary
-------

Review on behalf of Pedro Kiefer: cleanups from ASTERISK-20224, ASTERISK-20157 and the updated ASTERISK-16694 (author Fred van Lieshout) + improvement from ASTERISK-20158
There are several issues opened for bugs in app_alarmreceiver (ASTERISK-19435, ASTERISK-18417, ASTERISK-16694 and ASTERISK-16668), which go away after the cleanup (ASTERISK-16694) replacing the proprietary toneburst code with ast_playtones_ functions, so the fix from ASTERISK-19435 is no longer necessary.
The new functionality from ASTERISK-20158 is a bugfix on my opinion, because 'we get stuck on the alarm receiver app until it times out'


This addresses bugs ASTERISK-16668, ASTERISK-16694, ASTERISK-18417, ASTERISK-19435, ASTERISK-20157, ASTERISK-20158, and ASTERISK-20224.
    https://issues.asterisk.org/jira/browse/ASTERISK-16668
    https://issues.asterisk.org/jira/browse/ASTERISK-16694
    https://issues.asterisk.org/jira/browse/ASTERISK-18417
    https://issues.asterisk.org/jira/browse/ASTERISK-19435
    https://issues.asterisk.org/jira/browse/ASTERISK-20157
    https://issues.asterisk.org/jira/browse/ASTERISK-20158
    https://issues.asterisk.org/jira/browse/ASTERISK-20224


Diffs (updated)
-----

  /trunk/apps/app_alarmreceiver.c 370760 

Diff: https://reviewboard.asterisk.org/r/2075/diff


Testing
-------

Compile test only


Thanks,

KNK

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120817/84f7e088/attachment.htm>