[asterisk-dev] [Code Review] MixMonitor Leaves Empty Audio Files Behind

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2068/#review6911
-----------------------------------------------------------


I'm pretty sure this in in Asterisk 10 and up only, but MixMonitor can record up to three files simultaneously write three separate files (I think the options are 'r' and 't', but I'm not 100% sure), all of which would exhibit this problem. Two of them are unidirectional audio and one is the mixed audio stream. All of these should be addressed with this fix since they handle the file stream in the same basic manner.

- jrose


On Aug. 14, 2012, 4:49 p.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2068/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 4:49 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When the MixMonitor application is started, it creates an empty audio file (just the header is present) for writing an audio stream.
> 
> In the event that MixMonitor is started before dialing (in the case on the issue, record only a bridged channel) but the bridge never is setup due to the other side not answering or for whatever reason the bridge did not succeed in being created, MixMonitor does not clean up the empty audio file.  This has the effect of leaving empty audio files behind.
> 
> This proposed patch is a simple one.  I took a look at app_record to see how it handles files that do not contain any audio and proceeded to create this patch to match that behavior.
> 
> 
> This addresses bug ASTERISK-20156.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20156
> 
> 
> Diffs
> -----
> 
>   /branches/10/UPGRADE.txt 371249 
>   /branches/10/apps/app_mixmonitor.c 371249 
> 
> Diff: https://reviewboard.asterisk.org/r/2068/diff
> 
> 
> Testing
> -------
> 
> Reproducing this issue is pretty straight forward.  I tested this patch on one of my local dev machines.  I have yet to get a response on the issue as to whether it is working for the original reporter.
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120814/34aedc4e/attachment.htm>