[asterisk-dev] [Code Review] dialing through chan_local breaks t38 fax

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2070/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

See bug report. For this dialplan, faxing to 's' doesn't work, but faxing to 'fax' does. The patch fixes so it works. But I'm not familiar enough with T38 nor the indications to know if this is the right fix.

[default]
exten => s,1,Dial(Local/fax at default)

exten => fax,1,NoOp()
     same => n,ReceiveFAX(/tmp/abc.tiff)
     same => n,Hangup()


This addresses bug ASTERISK-20229.
    https://issues.asterisk.org/jira/browse/ASTERISK-20229


Diffs
-----

  /branches/1.8/channels/chan_local.c 371243 

Diff: https://reviewboard.asterisk.org/r/2070/diff


Testing
-------

On 1.6.2.x faxing works without the patch.
On 1.8.x faxing works on the 's' extension only after applying the patch.

I used the patched sipp from https://code.osso.nl/projects/sipp with the sendfax.xml and sendfax.pcap to replay a (lengthy) fax.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120814/d212b181/attachment.htm>