[asterisk-dev] [Code Review]: Changes from Mantis ID 13495 in trunk.

[Matt Jordan]

> On Aug. 9, 2012, 7:13 p.m., rmudgett wrote:
> > I took diff 11 and made the necessary changes from my findings in anticipation of getting this committed.
> > 
> > Unfortunately, when I tried to do some basic call testing, libss7 immediately went into an endless loop of unexpected message exchanges.
> > GRS ->
> >     <- GRA
> > Got GRA but we didn't send GRS on CIC resetting the cic
> > RLC ->
> >        Got RLC but we didn't send REL/RSC on CIC resetting the cic
> >     <- RLC
> > Got RLC but we didn't send REL/RSC on CIC resetting the cic
> > RLC ->
> >        Got RLC but we didn't send REL/RSC on CIC resetting the cic
> >     <- RLC
> > ..... both sides initiate this same message exchange to each other forever.
> > It appears to have something to do with the c->got_sent_msg flags and isup_handle_unexpected().
> > 
> > I got this with an Asterisk setup using DAHDI local spans to get a simulated back-to-back SS7 trunk.  You could do this or use a back-to-back T1/E1 link.
> > To configure the DAHDI local spans.
> > In system.conf:
> > # Dynamic local spans for SS7 trunk (DAHDI channels 1-23 map to 25-47 respectively and sigchan 23 maps to 48)
> > dynamic=loc,1:0,24,0
> > bchan=1-23
> > dchan=24
> > 
> > dynamic=loc,1:1,24,0
> > bchan=25-47
> > dchan=48
> > 
> > 
> > The libss7 code from review https://reviewboard.asterisk.org/r/1653/ is now on the resurrected libss7/trunk branch.  Any libss7 changes you need to do to fix the problem you can create a new review against the resurrected libss7 trunk.
> > 
> > The Asterisk code with my changes I was getting ready to commit is in the asterisk/team/rmudgett/ss7_27_knk branch.  The ss7_27_knk branch is automerging from trunk each hour so any updated diffs for this review need to be posted as a difference between trunk and ss7_27_knk.  Using a svn workspace of trunk and ss7_27_knk, the diff can be created like this:
> > Commands applied to the ss7_27_knk workspace:
> > svn pl -v
> > The output will have: ss7_27_knk-integrated : /trunk:1-371048
> > svn info
> > The output will have: Last Changed Rev: 371050
> > 
> > Applied to an unchanged trunk workspace:
> > Take the trunk revision from the ss7_27_knk-integrated property and the ss7_27_knk last changed revision:
> > svn merge URL-of-trunk at 371048 URL-of-ss7_27_knk at 371050
> > 
> > Getting Asterisk to build with these changes has a small trick needed since I want to defer recreating the ./configure script on the ss7_27_knk branch.
> > You need to run the ./configure script with libss7 v1.0 installed because I have already made the ./configure script tell the difference between v1.0 and the trunk libss7.  Then you need to install the libss7 trunk to build Asterisk.
> > 
> > Note that the new libss7 Makefile optimizes the code by default.  To build an unoptimized libss7 use:
> > make LIBSS7_OPT=
> > 
> > Richard

The end result of this is that we tried really, really hard to get this ready for the first beta of Asterisk 11.  Richard has spent the past several days (week?) working on this, but at this point, it looks like getting this in a state where its "done done" is going to take awhile still.

At this time, I'd like to defer this for the first beta.  If KNK and Richard can get the problems Richard has identified resolved within a reasonable time, we can talk about getting this in for a second beta.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1676/#review6900
-----------------------------------------------------------


On Aug. 6, 2012, 10:53 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1676/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 10:53 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi / sig_ss7 part of changes
> 
> 
> This addresses bug SS7-27.
>     https://issues.asterisk.org/jira/browse/SS7-27
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 370748 
>   trunk/channels/sig_ss7.h 370748 
>   trunk/channels/sig_ss7.c 370748 
>   trunk/configs/chan_dahdi.conf.sample 370748 
>   trunk/configs/ss7.timers.sample PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1676/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection.
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120810/c6967c71/attachment-0001.htm>