[asterisk-dev] [Code Review]: Bring the (missing) changes from Mantis ID 13495 in trunk.

[rmudgett]

> On Aug. 3, 2012, 7:06 p.m., rmudgett wrote:
> > The Makefile needs updating to build a new library version.
> > DYNAMIC_LIBRARY
> > 
> > It might be better to take the Makefile from libpri and modify that for libss7.
> 
> KNK wrote:
>     I don't have much experience with Makefiles, so it may take some time (to learn), while i am on leave this week and will not have the time, sorry. This will also require changes in Asterisk's Makefile (i guess) to pick the correct version. I will take a look on this next week - hope it won't be too late.

I have updated the Makefile from libpri's makefile.

I'll take this patch and complete it to get it committed for Asterisk 11.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1653/#review6876
-----------------------------------------------------------


On Aug. 2, 2012, 12:14 p.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1653/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2012, 12:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> libss7 part of the changes.
> Added additional cause codes, Transmission Medium Requirement setting and connected line to CPG messages + code cleanup.
> 
> 
> This addresses bugs SS7-21, SS7-27, SS7-28, SS7-33, SS7-36, SS7-38, SS7-39, SS7-40, SS7-42, SS7-43, SS7-45, SS7-46, SS7-47, SS7-48, SS7-49, SS7-51, SS7-52, SS7-53, SS7-54, and SS7-7.
>     https://issues.asterisk.org/jira/browse/SS7-21
>     https://issues.asterisk.org/jira/browse/SS7-27
>     https://issues.asterisk.org/jira/browse/SS7-28
>     https://issues.asterisk.org/jira/browse/SS7-33
>     https://issues.asterisk.org/jira/browse/SS7-36
>     https://issues.asterisk.org/jira/browse/SS7-38
>     https://issues.asterisk.org/jira/browse/SS7-39
>     https://issues.asterisk.org/jira/browse/SS7-40
>     https://issues.asterisk.org/jira/browse/SS7-42
>     https://issues.asterisk.org/jira/browse/SS7-43
>     https://issues.asterisk.org/jira/browse/SS7-45
>     https://issues.asterisk.org/jira/browse/SS7-46
>     https://issues.asterisk.org/jira/browse/SS7-47
>     https://issues.asterisk.org/jira/browse/SS7-48
>     https://issues.asterisk.org/jira/browse/SS7-49
>     https://issues.asterisk.org/jira/browse/SS7-51
>     https://issues.asterisk.org/jira/browse/SS7-52
>     https://issues.asterisk.org/jira/browse/SS7-53
>     https://issues.asterisk.org/jira/browse/SS7-54
>     https://issues.asterisk.org/jira/browse/SS7-7
> 
> 
> Diffs
> -----
> 
>   branches/1.0/isup.h 306 
>   branches/1.0/isup.c 306 
>   branches/1.0/libss7.h 306 
>   branches/1.0/mtp2.h 306 
>   branches/1.0/mtp2.c 306 
>   branches/1.0/mtp3.h 306 
>   branches/1.0/mtp3.c 306 
>   branches/1.0/parser_debug.c 306 
>   branches/1.0/ss7.c 306 
>   branches/1.0/ss7_internal.h 306 
>   branches/1.0/ss7linktest.c 306 
>   branches/1.0/ss7test.c 306 
> 
> Diff: https://reviewboard.asterisk.org/r/1653/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120809/50829836/attachment-0001.htm>