[asterisk-dev] [Code Review]: chan_sip: [general] maxforwards, not checked for a value greater than 255

Olle E. Johansson oej at edvina.net
Thu Apr 26 04:51:52 CDT 2012

26 apr 2012 kl. 11:37 skrev Alec Davis:

> This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/1888/
> On April 26th, 2012, 4:29 a.m., Olle E Johansson wrote:
> You are exactly right. My mistake. I can commit it if you can not. Just find me on IRC or e-mail.
> I can commit.

As I ask the US people to wait and not commit immediately, I would like for us on other time zones to respect them and at least keep a code review open for a day so there's room for discussion.

Now this was such a small fix (and rather obvious) so I don't mind and I don't think we'll see any objection when they wake up.

But in the future I ask all of us developers to be less trigger-happy with the commit after a ship-it on your time zone.


PS. This rule does not apply if someone quickly wants to change codec priority so ALAW comes before ULAW. Let's set a date and time and do it before the US guys know what happens. :-)

More information about the asterisk-dev mailing list