[asterisk-dev] [Code Review] Fix for customizing sound_leader_has_left in confbridge.conf

elguero reviewboard at asterisk.org
Wed Apr 25 09:15:23 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1884/#review6060
-----------------------------------------------------------

Ship it!


Looks good to me.

- elguero


On April 25, 2012, 8:43 a.m., Pawel Kuzak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1884/
> -----------------------------------------------------------
> 
> (Updated April 25, 2012, 8:43 a.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> The sound "sound_leader_has_left" in the confbridge.conf is currently not settable by the user. After checking the sources it seemed to me that the part for reading the user configuration for this sound is missing. I made a patch that I am using and I want to share it with you.
> 
> 
> This addresses bug ASTERISK-19771.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19771
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/confbridge/conf_config_parser.c 363635 
> 
> Diff: https://reviewboard.asterisk.org/r/1884/diff
> 
> 
> Testing
> -------
> 
> My Asterisk (Version 10.2.0) is running in a productive environment with this patch for almost one month without any complications. 
> 
> 
> Thanks,
> 
> Pawel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120425/cb2eafbd/attachment.htm>


More information about the asterisk-dev mailing list