[asterisk-dev] [Code Review] Make it possible to change DTMF min duration in asterisk.conf

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1882/#review6053
-----------------------------------------------------------



/trunk/main/asterisk.c
<https://reviewboard.asterisk.org/r/1882/#comment11101>

    This should never be a negative number,
    so should be declared as an 'unsigned int'



/trunk/main/asterisk.c
<https://reviewboard.asterisk.org/r/1882/#comment11102>

    never negative, use %u instead of %d



/trunk/main/asterisk.c
<https://reviewboard.asterisk.org/r/1882/#comment11095>

    Assuming option_dtmfminduration can never be negative.
     
    Can't the test for option_dtmfminduration < 0 be covered by using '%30u' in the sscanf option.


- Alec


On April 24, 2012, 5:03 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1882/
> -----------------------------------------------------------
> 
> (Updated April 24, 2012, 5:03 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In channel.c there's a DEFINE for a minimum DTMF duration. I've changed this in many installations. It is much more convienient to be able to change this in asterisk.conf
> 
> Also shows up in "core show settings" for verification.
> 
> Will update CHANGES.
> 
> 
> This addresses bug 19772.
>     https://issues.asterisk.org/jira/browse/19772
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 363322 
>   /trunk/configs/asterisk.conf.sample 363322 
>   /trunk/include/asterisk/options.h 363322 
>   /trunk/main/asterisk.c 363322 
>   /trunk/main/channel.c 363322 
> 
> Diff: https://reviewboard.asterisk.org/r/1882/diff
> 
> 
> Testing
> -------
> 
> It works for me.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120424/6f38722b/attachment-0001.htm>