[asterisk-dev] [Code Review]: Make it possible to change DTMF min duration in asterisk.conf

[Olle E Johansson]

> On April 24, 2012, 9:22 a.m., Leif Madsen wrote:
> > /trunk/CHANGES, line 30
> > <https://reviewboard.asterisk.org/r/1882/diff/2/?file=27520#file27520line30>
> >
> >     Would be ideal that it mentioned the option directly here so it's obvious what you might change.

Ok.


> On April 24, 2012, 9:22 a.m., Leif Madsen wrote:
> > /trunk/configs/asterisk.conf.sample, line 37
> > <https://reviewboard.asterisk.org/r/1882/diff/2/?file=27521#file27521line37>
> >
> >     Looks like a comment in the code says that the minimum can't be less than 80ms. Perhaps the wording just seems to imply that when what you meant to document was the default value.

The minimum can be much less than 80ms.


> On April 24, 2012, 9:22 a.m., Leif Madsen wrote:
> > /trunk/main/asterisk.c, line 160
> > <https://reviewboard.asterisk.org/r/1882/diff/2/?file=27523#file27523line160>
> >
> >     Assuming you just meant the default is 80ms, maybe s/80ms/Default value 80ms/
> >     
> >     When I first read this my brain processed it as you were stating what the minimum value was.

I can't patch your brain, but I can fix comments. Just copy/paste from old code in channel.c

Thanks for the review, Leif!


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1882/#review6043
-----------------------------------------------------------


On April 24, 2012, 5:03 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1882/
> -----------------------------------------------------------
> 
> (Updated April 24, 2012, 5:03 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In channel.c there's a DEFINE for a minimum DTMF duration. I've changed this in many installations. It is much more convienient to be able to change this in asterisk.conf
> 
> Also shows up in "core show settings" for verification.
> 
> Will update CHANGES.
> 
> 
> This addresses bug 19772.
>     https://issues.asterisk.org/jira/browse/19772
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 363322 
>   /trunk/configs/asterisk.conf.sample 363322 
>   /trunk/include/asterisk/options.h 363322 
>   /trunk/main/asterisk.c 363322 
>   /trunk/main/channel.c 363322 
> 
> Diff: https://reviewboard.asterisk.org/r/1882/diff
> 
> 
> Testing
> -------
> 
> It works for me.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120424/9006f3eb/attachment.htm>