[asterisk-dev] [Code Review]: Clean up cel.conf parsing

[Matt Jordan]

> On April 19, 2012, 12:50 p.m., Terry Wilson wrote:
> > It would be interesting to see how the config stuff I have in r1873 handles the cel_* modules. One thing I can see that I would need to add is the ability to ignore unknown context types, since each cel_* module only parses a part of the config file.
> 
> Paul Belanger wrote:
>     Indeed. This is actually and issue for 1.8 / 10 but I don't think we can apply this patch because of the change in functionality.  Or can we?

Unless we can specify a bug in the parsing of the CEL configuration files, then I would say this is trunk only.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1436/#review6024
-----------------------------------------------------------


On April 17, 2012, 8:02 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1436/
> -----------------------------------------------------------
> 
> (Updated April 17, 2012, 8:02 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This includes both [general] section for cel.conf.  Properly iterate through the configuration settings, this change was done to main/cdr.c before.
> 
> 
> Diffs
> -----
> 
>   trunk/main/cel.c 362370 
> 
> Diff: https://reviewboard.asterisk.org/r/1436/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120419/93d94817/attachment.htm>