[asterisk-dev] [Code Review] Update Asterisk Test Suite pre-/post-condition check framework to support asynchronous process management

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1831/
-----------------------------------------------------------

(Updated April 17, 2012, 6:02 p.m.)


Review request for Asterisk Developers.


Changes
-------

Updated with Kinsey's findings.


Summary
-------

This is a continuation of review https://reviewboard.asterisk.org/r/1821/.

The pre-/post-condition checking framework in the Asterisk Test Suite was not migrated over to handle the now asynchronous nature of the asterisk class.  As such, it failed to function properly.  Since this is not a heavily used feature, I waited until this review to migrate it over to handle twisted until this review.

This patch makes the framework and the various concrete implementations of TestCondition work in an asynchronous fashion.


Diffs (updated)
-----

  /asterisk/trunk/lib/python/asterisk/ChannelTestCondition.py 3157 
  /asterisk/trunk/lib/python/asterisk/FdTestCondition.py 3157 
  /asterisk/trunk/lib/python/asterisk/LockTestCondition.py 3157 
  /asterisk/trunk/lib/python/asterisk/SipDialogTestCondition.py 3157 
  /asterisk/trunk/lib/python/asterisk/TestCase.py 3157 
  /asterisk/trunk/lib/python/asterisk/TestConditions.py 3157 
  /asterisk/trunk/lib/python/asterisk/ThreadTestCondition.py 3157 

Diff: https://reviewboard.asterisk.org/r/1831/diff


Testing
-------

Tested each of the TestCondition derived objects on a variety of tests.  Test failures were reported as expected (for example, a test that had additional threads existing in Asterisk at the time of shutdown was reported as having those threads existing).  Tested file descriptors, locks, channels, SIP dialogs, and threads.


Thanks,

Matt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120417/9194959f/attachment.htm>