[asterisk-dev] [Code Review] Fix the fact that meetme saves recordings that aren't sent to an absolute path to the wrong directory.

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1846/#review5987
-----------------------------------------------------------

Ship it!


Looks good to me!

- opticron


On April 6, 2012, 10:16 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1846/
> -----------------------------------------------------------
> 
> (Updated April 6, 2012, 10:16 a.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, rmudgett, and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Apparently we made no effort to deal with paths for meetme recordings earlier, so the recording function would just send it to the default place for recordings... the sound folder.
> 
> This adds some path parsing and creates a full path name to the spool/meetme directory instead. This seems appropriate, though before the only thing that would automatically get stored in the spool/meetme folder would be recordings of names.
> 
> 
> This addresses bug ASTERISK-19164.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19164
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_meetme.c 361261 
> 
> Diff: https://reviewboard.asterisk.org/r/1846/diff
> 
> 
> Testing
> -------
> 
> Tested directories that need to have their paths built
> (as in strings for recording like "FOO/BAR/myrecording")
> 
> Tested with just the recording name
> (as in strings for recording like "recordingbleh"
> 
> Tested with full path to make sure I didn't break it
> (like "/FOOBAR/STARFISH/MONKEY/NINJA/LEMUR/MANTIS/record")
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120413/b9db8396/attachment.htm>