[asterisk-dev] [Code Review] Group write permission removed from existing directory /etc/asterisk/

Tilghman Lesher reviewboard at asterisk.org
Thu Apr 12 11:09:13 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1864/#review5984
-----------------------------------------------------------


This change will break the Mac OS X build, which uses standard paths with spaces in them, e.g. "ASTVARLIBDIR=/Library/Application Support/Asterisk".

- Tilghman


On April 12, 2012, 9:22 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1864/
> -----------------------------------------------------------
> 
> (Updated April 12, 2012, 9:22 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> We now check if the install directory has already been created, if so don't bother to create it.  Since 'install -d' overwrites existing permissions.
> 
> 
> This addresses bug asterisk-19492.
>     https://issues.asterisk.org/jira/browse/asterisk-19492
> 
> 
> Diffs
> -----
> 
>   branches/1.8/Makefile 361954 
> 
> Diff: https://reviewboard.asterisk.org/r/1864/diff
> 
> 
> Testing
> -------
> 
> Local development box.  ./contrib/scripts/live_ast
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120412/af49050f/attachment.htm>


More information about the asterisk-dev mailing list