[asterisk-dev] [Code Review] Add tests for SIP_CAUSE and its replacement

Matt Jordan reviewboard at asterisk.org
Thu Apr 12 08:28:33 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1832/#review5977
-----------------------------------------------------------

Ship it!


Looks good!

- Matt


On March 27, 2012, 11:23 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1832/
> -----------------------------------------------------------
> 
> (Updated March 27, 2012, 11:23 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add tests for SIP_CAUSE and its replacement (currently named HANGUPCAUSE, may be something else later).  Both tests check the non-hash HANGUPCAUSE variable to ensure that no namespace collision occurs and include tests for single channel dials, branched dials, and local channel indirected branched dials.
> 
> 
> This addresses bug SWP-4223.
>     https://issues.asterisk.org/jira/browse/SWP-4223
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/SIP/sip_cause/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/tests.yaml 3162 
>   asterisk/trunk/tests/channels/SIP/sip_cause/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/sip_cause/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/sip_cause/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/sip_cause/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/sip_cause/run-test PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/hangupcause/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/hangupcause/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/hangupcause/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/hangupcause/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/hangupcause/run-test PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/hangupcause/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1832/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120412/6d83cc44/attachment.htm>


More information about the asterisk-dev mailing list