[asterisk-dev] [Code Review] Add option to invoke the extensions.conf stdexten using the legacy macro method.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1855/#review5976
-----------------------------------------------------------

Ship it!


Always good to support legacy stuff, even when we said we deprecated it multiple versions ago (and just now got around to actually doing so)

- Matt


On April 6, 2012, 7:22 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1855/
> -----------------------------------------------------------
> 
> (Updated April 6, 2012, 7:22 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add an option to asterisk.conf to generate stdexten dialplans using the new gosub method or legacy macro method.
> 
> users.conf:
>  - A defined user with hasvoicemail=yes now finally uses a Gosub to stdexten
>    as documented in extensions.conf.sample since v1.6.0 instead of a Macro as
>    documented in v1.4.  Set the asterisk.conf stdexten=macro parameter to
>    invoke the stdexten the old way.
> 
> 
> This addresses bug ASTERISK-19457.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19457
> 
> 
> Diffs
> -----
> 
>   /trunk/UPGRADE.txt 361609 
>   /trunk/configs/asterisk.conf.sample 361609 
>   /trunk/include/asterisk/options.h 361609 
>   /trunk/main/asterisk.c 361609 
>   /trunk/pbx/pbx_config.c 361609 
> 
> Diff: https://reviewboard.asterisk.org/r/1855/diff
> 
> 
> Testing
> -------
> 
> Setting the stdexten parameter in asterisk.conf to macro, gosub, other worked as expected.
> When set to macro, the users.conf extension was created to invoke a macro.
> When set to gosub, the users.conf extension was created to invoke a gosub.
> When set to something else, the option defaulted to gosub.
> When the option is not present, the option defaulted to gosub.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120412/756ed164/attachment-0001.htm>