[asterisk-dev] [Code Review] Change default for 'ignorebusy' and document some of the effects

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1860/#review5965
-----------------------------------------------------------

Ship it!


For Asterisk 10, there's not much choice here other than to do this so that things behave as expected.

- Mark


On April 9, 2012, 10:40 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1860/
> -----------------------------------------------------------
> 
> (Updated April 9, 2012, 10:40 a.m.)
> 
> 
> Review request for Asterisk Developers, irroot and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Users were reporting a behavioral change in 10 from 1.8 invloving queues and the setting of 'ringinuse' not having any effect.  Tracking this down revealed this to be caused by the ignorebusy setting defaulting to 0 in Asterisk 10 with its effects occuring when it was set to off.
> 
> This patch changes the default to 1 in Asterisk 10. Some additional changes are in progress for Trunk since we can do more with that.  I assume the reason this slipped past irroot in the first place is because it was designed from the perspective of realtime queues.
> 
> 
> This addresses bug ASTERISK-19536.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19536
> 
> 
> Diffs
> -----
> 
>   /branches/10/CHANGES 361654 
>   /branches/10/apps/app_queue.c 361654 
>   /branches/10/configs/queues.conf.sample 361654 
> 
> Diff: https://reviewboard.asterisk.org/r/1860/diff
> 
> 
> Testing
> -------
> 
> Tested values at startup and made sure the ringinuse setting had an effect on queue member selection.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120411/915d477b/attachment-0001.htm>