[asterisk-dev] [Code Review] Rip out PROC selection in Asterisk makefiles

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1852/
-----------------------------------------------------------

(Updated April 10, 2012, 2:07 p.m.)


Review request for Asterisk Developers.


Changes
-------

Take user-defined CFLAGS into account when allowing or disallowing -march=native in menuselect.


Summary
-------

The selection of PROC as k8 for -march on 64bit systems can cause gcc to create binaries that will not run on the local machine since it will optimize to use 3Dnow! and extended 3Dnow! instructions where possible.  This type of code shouldn't even really be in the Asterisk build system so I'm ripping it out in its entirety instead of changing k8 to native.  There is now a menuselect option that is available when a version of gcc that supports -march=native is being used to enable or disable tailoring of generated code to the instruction sets available on the local CPU.


This addresses bug ASTERISK-19462.
    https://issues.asterisk.org/jira/browse/ASTERISK-19462


Diffs (updated)
-----

  branches/1.8/Makefile 361490 
  branches/1.8/Makefile.rules 361490 
  branches/1.8/build_tools/cflags.xml 361490 
  branches/1.8/build_tools/menuselect-deps.in 361490 
  branches/1.8/codecs/gsm/Makefile 361490 
  branches/1.8/codecs/gsm/src/k6opt.s 361490 
  branches/1.8/codecs/lpc10/Makefile 361490 
  branches/1.8/configure UNKNOWN 
  branches/1.8/configure.ac 361490 
  branches/1.8/makeopts.in 361490 

Diff: https://reviewboard.asterisk.org/r/1852/diff


Testing
-------

Ran this through the testsuite and it didn't break anything.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120410/48fe5303/attachment-0001.htm>