[asterisk-dev] [Code Review] Trunk changes for queue ignorebusy. Allow setting of ignorebusy on a queue member through configs, CLI, and AMI.

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1861/#review5957
-----------------------------------------------------------



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1861/#comment10905>

    This last NULL return is unnessary.


- jrose


On April 9, 2012, 12:59 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1861/
> -----------------------------------------------------------
> 
> (Updated April 9, 2012, 12:59 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, irroot, and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This patch adds methods to set the queue member value ignorebusy through AMI commands, CLI, and while creating a member via configs.  They are all based on the equivalent methods for setting queue penalties.
> 
> 
> This addresses bug ASTERISK-19536.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19536
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_queue.c 361654 
>   /trunk/configs/queues.conf.sample 361654 
> 
> Diff: https://reviewboard.asterisk.org/r/1861/diff
> 
> 
> Testing
> -------
> 
> Mostly just using each of the different values in a variety of ways to set the ignorebusy value and then checking whether the flag was raised or not with the CLI show queue command (which I added some display for.  It displays (not ignorebusy) when the flag is lowered since ignorebusy is the normal state... in spite of the double negative terminology which makes me cringe.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120409/d8bf1eb3/attachment.htm>