[asterisk-dev] [Code Review] Rip out PROC selection in Asterisk makefiles

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1852/#review5949
-----------------------------------------------------------


Are you proposing this for 1.8? or trunk only?  My vote is for trunk, since we've had problems in the past when changing the build process mid branch.

- Paul


On April 6, 2012, 10:18 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1852/
> -----------------------------------------------------------
> 
> (Updated April 6, 2012, 10:18 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The selection of PROC as k8 for -march on 64bit systems can cause gcc to create binaries that will not run on the local machine since it will optimize to use 3Dnow! and extended 3Dnow! instructions where possible.  This type of code shouldn't even really be in the Asterisk build system so I'm ripping it out in its entirety instead of changing k8 to native.
> 
> One downside of this change is that Asterisk will now be slightly less optimized by default than previously.
> 
> 
> This addresses bug ASTERISK-19462.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19462
> 
> 
> Diffs
> -----
> 
>   branches/1.8/Makefile 361090 
>   branches/1.8/codecs/gsm/Makefile 361090 
>   branches/1.8/codecs/gsm/src/k6opt.s 361090 
>   branches/1.8/codecs/lpc10/Makefile 361090 
>   branches/1.8/makeopts.in 361090 
> 
> Diff: https://reviewboard.asterisk.org/r/1852/diff
> 
> 
> Testing
> -------
> 
> Ran this through the testsuite and it didn't break anything.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120406/28635647/attachment.htm>