[asterisk-dev] [Code Review] clean up va_args va_end usage in utils and res_config_odbc

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1847/
-----------------------------------------------------------

Review request for Asterisk Developers, Mark Michelson, wdoekes, and Matt Jordan.


Summary
-------

A number of va_copy operations weren't matched with a corresponding va_end in res_config_odbc. Also, there was a potential for va_end to be invoked twice on the same va_arg in utils, which would mean invoking va_end on an undefined variable... which is bad.


This addresses bug ASTERISK-19451.
    https://issues.asterisk.org/jira/browse/ASTERISK-19451


Diffs
-----

  /branches/1.8/main/utils.c 361291 
  /branches/1.8/res/res_config_odbc.c 361291 

Diff: https://reviewboard.asterisk.org/r/1847/diff


Testing
-------

Totally untested (not really sure how to test it), so approach with caution.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120405/2e9d3c46/attachment.htm>