[asterisk-dev] [Code Review] Add config parsing example code to app_skel
Paul Belanger
reviewboard at asterisk.org
Wed Apr 4 09:26:16 CDT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1841/#review5931
-----------------------------------------------------------
/trunk/apps/app_skel.c
<https://reviewboard.asterisk.org/r/1841/#comment10883>
If a user wants to 'stack' categories they should be doing the following:
[pvt1]
description=blah
permit=127.0.0.1/32
[pvt2]
description=blahblahblah
[pvt1](+)
allow=!all,ulaw
I would say you example is a configuration error.
- Paul
On April 2, 2012, 2:50 p.m., Terry Wilson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1841/
> -----------------------------------------------------------
>
> (Updated April 2, 2012, 2:50 p.m.)
>
>
> Review request for Asterisk Developers, rmudgett and Matt Jordan.
>
>
> Summary
> -------
>
> This patch adds config parsing to app_skel to serve as an example of how to properly write config handling using the ao2 global object API for thread-safe reloads. I also made a couple of whitespace changes even though they technically should have gone in a separate patch, but they didn't get in the way of seeing what changed, etc.
>
>
> Diffs
> -----
>
> /trunk/apps/app_skel.c 360984
> /trunk/configs/app_skel.conf.sample PRE-CREATION
>
> Diff: https://reviewboard.asterisk.org/r/1841/diff
>
>
> Testing
> -------
>
> "skel show config/privates" and "memory show summary app_skel.c/config.c"
>
>
> Thanks,
>
> Terry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120404/43b5568e/attachment-0001.htm>
More information about the asterisk-dev
mailing list