[asterisk-dev] [Code Review] Make MeetMeAdmin command N (mute all nonadmins) not mute admins

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1843/#review5930
-----------------------------------------------------------

Ship it!


Yay!

- Mark


On April 3, 2012, 3:39 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1843/
> -----------------------------------------------------------
> 
> (Updated April 3, 2012, 3:39 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This bug was introduced when jpeeler did a major overhaul in MeetMe to prevent deadlocks by using ao2_callbacks.  He added a condition which checked for the presence of a pointer to the conference which wasn't included with all of the ao2_callback calls which used those function pointers.  This patch looked over the other call to user_set_muted_cb which worked fine and applied the difference (inclusion of a pointer to the conference) elsewhere.
> 
> Noting that, I applied the same thing to a few other similar commands in the area.
> 
> https://reviewboard.asterisk.org/r/746/
> This is a review for the patch which appears to have introduced this.
> 
> 
> This addresses bug ASTERISK-19335.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19335
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_meetme.c 361037 
> 
> Diff: https://reviewboard.asterisk.org/r/1843/diff
> 
> 
> Testing
> -------
> 
> So far I've mostly just tested with the dialplan shown in the issue.  It appears to work properly now.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120403/ec422bac/attachment.htm>