[asterisk-dev] [Code Review] Make mixmonitor recording to voicemail option delete source file once copies are made

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1842/#review5926
-----------------------------------------------------------



/branches/1.8-digiumphones/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/1842/#comment10878>

    This sort of malloc/free pair is a bit overkill. When dealing with filenames, a safe thing to do is to declare it as
    
    char filename[PATH_MAX];
    
    And then you can just use snprintf to populate the buffer.


- Mark


On April 3, 2012, 12:31 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1842/
> -----------------------------------------------------------
> 
> (Updated April 3, 2012, 12:31 p.m.)
> 
> 
> Review request for Asterisk Developers, Jason Parker and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This is a fairly simple change.  It just adds some stuff to delete the file the voicemails are copied from and changes some documentation.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8-digiumphones/apps/app_mixmonitor.c 361035 
> 
> Diff: https://reviewboard.asterisk.org/r/1842/diff
> 
> 
> Testing
> -------
> 
> Ran though mixmonitor with voicemail copy a few times and made sure it got deleted properly.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120403/d3fc7aae/attachment.htm>