[asterisk-dev] [Code Review]: Patch adds ability to ami hangup to specify a regex pattern to match channels against

[kobaz]

> On April 2, 2012, 9:06 a.m., opticron wrote:
> > trunk/main/manager.c, line 3167
> > <https://reviewboard.asterisk.org/r/1827/diff/5/?file=26941#file26941line3167>
> >
> >     Move the ast_str creation under the non-regex block so it doesn't leak if the channel isn't a regex.

Yeah... I had it like that but then reworked the block to reduce indent.  I'm a fan of less indentation too.

All fixed...


- kobaz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1827/#review5917
-----------------------------------------------------------


On April 2, 2012, 3:29 p.m., kobaz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1827/
> -----------------------------------------------------------
> 
> (Updated April 2, 2012, 3:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Patch adds ability to ami hangup to specify a regex pattern to match channels against
> 
> 
> This addresses bug ASTERISK-19575.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19575
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/manager.h 360459 
>   trunk/include/asterisk/strings.h 360459 
>   trunk/main/channel.c 360459 
>   trunk/main/manager.c 360459 
>   trunk/main/utils.c 360459 
>   trunk/include/asterisk/channel.h 360459 
> 
> Diff: https://reviewboard.asterisk.org/r/1827/diff
> 
> 
> Testing
> -------
> 
> Action:   Hangup
> Channel:  /Local/foo.*/
> ActionID: foo
> 
> Action:   Hangup
> Channel:  /SIP/foo.*/
> 
> 
> Thanks,
> 
> kobaz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120402/dcf034a9/attachment.htm>