[asterisk-dev] [Code Review] Use new ao2_global_obj API to clean up udptl.c config parsing/reloading

Terry Wilson reviewboard at asterisk.org
Mon Apr 2 14:06:24 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1840/
-----------------------------------------------------------

Review request for Asterisk Developers and Matt Jordan.


Summary
-------

This patch builds off of https://reviewboard.asterisk.org/r/1455/.

The differences are:
1) Uses the global ao2 object API to store config values and to make reloads thread-safe
2) Uses ast_parse_arg() where appropriate
3) Updates ast_parse_arg to be able to set defaults to the min/max range value on range errors
4) Adds CLI command 'udptl show config'


Diffs
-----

  /trunk/include/asterisk/config.h 360980 
  /trunk/main/config.c 360980 
  /trunk/main/udptl.c 360980 

Diff: https://reviewboard.asterisk.org/r/1840/diff


Testing
-------

1) Used the new 'udptl show config' command to verify that settings looked right on load/reload.
2) Did testing with 'memory show summary config.c/udptl.c' with loads/reloads to verify there are no leaks
3) Loaded with no config file to verify that default values were used


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120402/4d25a73e/attachment.htm>


More information about the asterisk-dev mailing list