No subject
Fri Sep 2 03:59:05 CDT 2011
od to go. I'm not one to be able to state whether the code is necessarily "=
pythonic" enough, though.
- Mark
On May 1, 2012, 4:32 p.m., Matt Jordan wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1893/
> -----------------------------------------------------------
> =
> (Updated May 1, 2012, 4:32 p.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> This reworks the leave_voicemail_contexts test to:
> 1) Use the TEST_FRAMEWORK and test events to control the test, as opposed=
to a lot of Wait() statements
> 2) Actually test valid extensions that VoiceMail has a hope and a prayer =
of bouncing a user out to
> 3) Test the conditions that currently fail in Asterisk, namely the d(cont=
ext) option failing if the extension the user attempts to go to does not ex=
ist in the current dialplan context.
> =
> This review being checked in is contingent on review 1892 being approved.
> =
> =
> This addresses bug ASTERISK-18243.
> https://issues.asterisk.org/jira/browse/ASTERISK-18243
> =
> =
> Diffs
> -----
> =
> /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/test-conf=
ig.yaml 3212 =
> /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/a=
st1/extensions.conf 3212 =
> /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/a=
st1/voicemail.conf 3212 =
> /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/a=
st2/extensions.conf 3212 =
> /asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/run-test =
3212 =
> =
> Diff: https://reviewboard.asterisk.org/r/1893/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Matt
> =
>
--===============8836231752473555219==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"https://reviewboard.asterisk.org/r/1893/">https://reviewbo=
ard.asterisk.org/r/1893/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From a pur=
e "code does what it is supposed to" point of view, I say it'=
s good to go. I'm not one to be able to state whether the code is neces=
sarily "pythonic" enough, though.</pre>
<br />
<p>- Mark</p>
<br />
<p>On May 1st, 2012, 4:32 p.m., Matt Jordan wrote:</p>
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('https://reviewboard.asterisk.org/media/r=
b/images/review_request_box_top_bg.png'); background-position: left top; ba=
ckground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style=3D"color: grey;"><i>Updated May 1, 2012, 4:32 p.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">This reworks the leave_voicemail_contexts test to:
1) Use the TEST_FRAMEWORK and test events to control the test, as opposed t=
o a lot of Wait() statements
2) Actually test valid extensions that VoiceMail has a hope and a prayer of=
bouncing a user out to
3) Test the conditions that currently fail in Asterisk, namely the d(contex=
t) option failing if the extension the user attempts to go to does not exis=
t in the current dialplan context.
This review being checked in is contingent on review 1892 being approved.</=
pre>
</td>
</tr>
</table>
<div style=3D"margin-top: 1.5em;">
<b style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href=3D"https://issues.asterisk.org/jira/browse/ASTERISK-18243">ASTERIS=
K-18243</a>
</div>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/test-con=
fig.yaml <span style=3D"color: grey">(3212)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/=
ast1/extensions.conf <span style=3D"color: grey">(3212)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/=
ast1/voicemail.conf <span style=3D"color: grey">(3212)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/configs/=
ast2/extensions.conf <span style=3D"color: grey">(3212)</span></li>
<li>/asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/run-test=
<span style=3D"color: grey">(3212)</span></li>
</ul>
<p><a href=3D"https://reviewboard.asterisk.org/r/1893/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8836231752473555219==--
More information about the asterisk-dev
mailing list