No subject

nd with my change the phone wasn't sent the timeout to the device.

I'm wondering why we didn't finish up with 2 MWI subscriptions, there may b=
e a clue there, did the code kill off the previous mwi subscription when an=
other for the same device arrived, or did the phone unsubscribe.


- Alec


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1813/#review5867
-----------------------------------------------------------


On March 13, 2012, 5:35 p.m., Alec Davis wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1813/
> -----------------------------------------------------------
> =

> (Updated March 13, 2012, 5:35 p.m.)
> =

> =

> Review request for Asterisk Developers.
> =

> =

> Summary
> -------
> =

> Some phones (Grandstream GXP20XX series 1.2.5.3 firmware) if rebooted, lo=
ose the BLF lights due to the new subscription's "version" being less than =
the previous subscription's "version".
> This happens the instant that asterisk timeouts the previous subscription=
 - which has the much larger "version" sequence number.
> =

> The only way for the lights to start working again, is for the current su=
bscription's "version" number to increment past the previous old "version" =
number.
> That period of time could be huge, if the phone isn't rebooted for days.
> =

> The workaround has been to reboot the phone twice, within a few minutes o=
f each reboot.
>   1st time wait for the BLF's to fail (then reboot again) - which is the =
timeout period - a few minutes.
>   2nd time the lights will work, then fail, then after a few minutes star=
t working again.
> =

> This fix prevents the old subscription timeout from updating the phones "=
version" number. =

> =

> This issue doesn't affter the GXP21XX series.
> =

> Attempt to show issue byway of example below with some debug output showi=
ng call-id and version number.
> =

> astrid-test*CLI> core show hints
> =

>     -=3D Registered Asterisk Dial Plan Hints =3D-
>             8601GXP0001 at trusted             : Custom:q8601_a8612    State=
:InUse           Watchers  1
> Debug output:
> =

> =3D=3D=3DSet the BLF state to InUse
> - Executing [s at macro-custom-agent-inout:13] Set("SIP/GXP0001-00000005", "=
DEVICE_STATE(Custom:q8601_a8612)=3DINUSE") in new stack
> ...
> [Mar 14 11:01:39] NOTICE[10819]: chan_sip.c:13136 state_notify_build_xml:=
 ALEC <dialog id=3D"8601GXP0001" call-id=3D"3c65aed02ae1d5df at 192.168.5.141"=
> version=3D5
> =

> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> Reboot the phone, it gets a new BLF subscription.
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> [Mar 14 11:02:30] NOTICE[10826]: chan_sip.c:13136 state_notify_build_xml:=
 ALEC <dialog id=3D"8601GXP0001" call-id=3D"79956c0168125400 at 192.168.5.141"=
> version=3D0
> =3D=3D=3DThe BLF has correct state of InUse.
> =

> ...
> [Mar 14 11:05:00] NOTICE[10826]: chan_sip.c:13136 state_notify_build_xml:=
 ALEC <dialog id=3D"8601GXP0001" call-id=3D"79956c0168125400 at 192.168.5.141"=
> version=3D1
> =3D=3D=3DThe BLF still has correct state of InUse.
> =

> ...
> The timeout 'last notification'
> [Mar 14 11:05:09] NOTICE[10826]: chan_sip.c:13131 state_notify_build_xml:=
 ALEC <dialog id=3D"8601GXP0001" call-id=3D"3c65aed02ae1d5df at 192.168.5.141"=
 direction=3D"recipient"> version=3D6
> [Mar 14 11:05:09] NOTICE[10826]: chan_sip.c:3868 __sip_autodestruct: ALEC=
 TIMEOUT of SIP subscription 3c65aed02ae1d5df at 192.168.5.141
> =3D=3D=3DThe BLF has incorrectly gone Idle.
> =

> ...
> [Mar 14 11:15:01] NOTICE[10826]: chan_sip.c:13136 state_notify_build_xml:=
 ALEC <dialog id=3D"8601GXP0001" call-id=3D"79956c0168125400 at 192.168.5.141"=
> version=3D5
> =3D=3D=3DThe BLF is still incorrect at Idle.
> =

>     -- Registered SIP 'GXP0001' at 192.168.5.141:5066
> [Mar 14 11:17:31] NOTICE[10826]: chan_sip.c:13136 state_notify_build_xml:=
 ALEC <dialog id=3D"8601GXP0001" call-id=3D"79956c0168125400 at 192.168.5.141"=
> version=3D6
> =3D=3D=3DThe BLF now has correct state of InUse.
> =

> =

> Diffs
> -----
> =

>   trunk/channels/chan_sip.c 358608 =

> =

> Diff: https://reviewboard.asterisk.org/r/1813/diff
> =

> =

> Testing
> -------
> =

> In place on a 1.8 deployment for months, our production box with ~80 GXP =
phones, half of which are the older GXP20XX series.
> =

> =

> Thanks,
> =

> Alec
> =

>


--===============5040727644451418195==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable




<html>
 <body>
  <div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"https://reviewboard.asterisk.org/r/1813/">https://reviewbo=
ard.asterisk.org/r/1813/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; padd=
ing-left: 10px;">
 <p style=3D"margin-top: 0;">On March 22nd, 2012, 6:14 p.m., <b>Mark Michel=
son</b> wrote:</p>
 <blockquote style=3D"margin-left: 1em; border-left: 2px solid #d0d0d0; pad=
ding-left: 10px;">
  <pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-sp=
ace: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No.